fix:added sonner for valhalla warning#386
Open
rohhann12 wants to merge 1 commit intovalhalla:masterfrom
Open
Conversation
Member
|
yeah, thanks a lot! this is long overdue and the last GSoC PR trying to solve it failed quite miserably. you even made the effort to find a live example, that's exactly the kind of thing I wanted to see here! |
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Adds warning sonner to the user
Closes #45
👨💻 Changes proposed
Files touched-
-Added warning type definitions in types.ts —
src/components/types.ts-Added shared warning toast utility in valhalla.ts —
src/utils/valhalla.ts-Display Valhalla warnings in route, isochrone, and optimized route hooks --
src/hooks/use-directions-queries.ts&&src/hooks/use-isochrones-queries.ts&&src/hooks/use-optimized-route-query.ts📄 Note to reviewers
Added
Warningtype andshowValhallaWarnings()utilityDisplay API warnings as toasts for route, isochrone, and optimized route endpoints
Uses existing sonner toast setup — no new UI components.
📷 Screenshots
Screen.Recording.2026-03-18.at.8.41.21.PM.mov